Skip to content

fix: RemoveOwnership not locally notifying server that it gained ownership [MTT-6377] [MTT-6937][MTT-6936]#2618

Merged
NoelStephensUnity merged 13 commits intodevelopfrom
fix/remove-ownership-server-notification-MTT-6377
Jul 14, 2023
Merged

fix: RemoveOwnership not locally notifying server that it gained ownership [MTT-6377] [MTT-6937][MTT-6936]#2618
NoelStephensUnity merged 13 commits intodevelopfrom
fix/remove-ownership-server-notification-MTT-6377

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity commented Jul 11, 2023 •
edited
Loading

This resolves a few ownership related issues specifically noticed when using an owner authoritative NetworkTransform and ownership is removed.

This also assures NetworkVariables will be updated if ownership is removed just like they are when ownership is changed.

This also fixes an issue where NetworkManager's ShutdownInProgress was not true upon the application quitting which was causing an exception to occur within NetworkVariableBase under specific conditions.

MTT-6936
MTT-6937
MTT-6377

fix: #2563
fix: #2606
fix: #2511
fix: #2629

Changelog

  • Fixed: issue where removing ownership would not notify the server that it gained ownership. This also resolves the issue where an owner authoritative NetworkTransform would not properly initialize upon removing ownership from a remote client.

Testing and Documentation

  • Includes modifications to existing integration tests.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
c958150 
This resolves a few ownership related issues specifically noticed when using an owner authoritative NetworkTransform and ownership is removed.
This also assures NetworkVariables will be updated if ownership is removed just like they are when ownership is changed.
This also fixes an issue where NetworkManager's ShutdownInProgress was not true upon the application quitting which was causing an exception to occur within NetworkVariableBase under specific conditions.
@NoelStephensUnity
update
90a1b0d 
adding change log entry
@NoelStephensUnity
test
c7503f0 
Removing a warning expect check that is no longer needed.
Adding additional checks to validate RemoveOwnership generates an OnOwnershipChanged notification.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review July 11, 2023 22:21
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner July 11, 2023 22:21
@NoelStephensUnity
style
00aba35 
removing some whacked auto-inserted using statement that VS 2022 "helped me" with.
@NoelStephensUnity
style
0be67ed 
 removing whitespaces
@NoelStephensUnity NoelStephensUnity mentioned this pull request Jul 12, 2023
Closed
ShadauxCat
ShadauxCat reviewed Jul 12, 2023
View reviewed changes
Comment thread com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
@NoelStephensUnity NoelStephensUnity changed the title fix: RemoveOwnership not locally notifying server that it gained ownership [MTT-6377] fix: RemoveOwnership not locally notifying server that it gained ownership [MTT-6377] [MTT-6937] Jul 13, 2023
@NoelStephensUnity NoelStephensUnity changed the title fix: RemoveOwnership not locally notifying server that it gained ownership [MTT-6377] [MTT-6937] fix: RemoveOwnership not locally notifying server that it gained ownership [MTT-6377] [MTT-6937][MTT-6936] Jul 13, 2023
@NoelStephensUnity NoelStephensUnity mentioned this pull request Jul 14, 2023
Closed
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) July 14, 2023 20:13
@NoelStephensUnity NoelStephensUnity merged commit 208d1c9 into develop Jul 14, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/remove-ownership-server-notification-MTT-6377 branch July 14, 2023 21:03
@NoelStephensUnity NoelStephensUnity mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment